Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): change light select hover color token #5150

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jan 23, 2020

Closes #5136

This PR updates the hover color token for light <Select>s

Changelog

Changed

  • hover color token for light <Select> variant

Testing / Reviewing

Ensure the component and all variants are visually correct on all themes

@emyarod emyarod requested a review from a team as a code owner January 23, 2020 16:24
@ghost ghost requested review from abbeyhrt and dakahn January 23, 2020 16:24
@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for the-carbon-components ready!

Built with commit aaf8073

https://deploy-preview-5150--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for carbon-elements ready!

Built with commit aaf8073

https://deploy-preview-5150--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for carbon-components-react ready!

Built with commit aaf8073

https://deploy-preview-5150--carbon-components-react.netlify.com

@emyarod emyarod force-pushed the 5136-themed-light-select-hover-bgc branch from 656d44d to be6b7dd Compare January 27, 2020 15:40
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍🏻

@asudoh asudoh merged commit 76f8009 into carbon-design-system:master Jan 28, 2020
@emyarod emyarod deleted the 5136-themed-light-select-hover-bgc branch January 28, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover background color for Select component is wrong in G10 theme
6 participants